Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: Don't bundle gwt-dev.jar
......................................................................
Patch Set 2: (1 inline comment)
Thanks Juan for submitting this patch.
....................................................
File pom.xml
Line 273: <!-- We avoid having gwt-dev.jar in the runtime class path
adding
Line 274: to the frontend.jar file the classes that the GWT
direct-eval
Line 275: RPC (deRPC) needs, that way we can set the scope of this
Line 276: dependency as provided and it won't be added to the
generated
Line 277: .war files: -->
I think this comment isn't really necessary since this patch just reverts the
scope of gwt-dev back to provided, gwt-dev shouldn't be on runtime classpath
anyway.
Line 278: <dependency>
Line 279: <groupId>com.google.gwt</groupId>
Line 280: <artifactId>gwt-dev</artifactId>
Line 281: <version>${gwt.version}</version>
--
To view, visit http://gerrit.ovirt.org/17264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0555b185ea8c52469ebe0779f5287b5bd824a569
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
