Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: hardware: Remove null character from the id on IBM POWER
......................................................................
Patch Set 1: (1 inline comment)
Nice one!
....................................................
File src/plugins/ovirt-host-deploy/vdsm/vdsmid.py
Line 109: elif arch in ('ppc', 'ppc64'):
Line 110: #eg. output IBM,03061C14A
Line 111: if os.path.exists('/proc/device-tree/system-id'):
Line 112: with open('/proc/device-tree/system-id') as f:
Line 113: vdsmId = f.readline().replace(',',
'').rstrip('\0')
can we please have f.readline().rstrip('\0').... ?
Line 114:
Line 115: if vdsmId is None:
Line 116: vdsmId = str(uuid.uuid4())
Line 117:
--
To view, visit http://gerrit.ovirt.org/17279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia74ac58d334c944c6042f033d622a09b86c8325d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
