Yedidyah Bar David has posted comments on this change.
Change subject: host-deploy: use pyar instead of tar
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1064: @Reloadable
Line 1065: @TypeConverterAttribute(String.class)
Line 1066: @DefaultValueAttribute(
Line 1067: "umask 0077; " +
Line 1068: "MYTMP=\"$(mktemp -d -t ovirt-XXXXXXXXXX)\"; " +
mktemp -t is marked [deprecated] in the manpage
Line 1069: "trap \"chmod -R u+rwX \\\"${MYTMP}\\\" > /dev/null 2>&1; rm
-fr \\\"${MYTMP}\\\" > /dev/null 2>&1\" 0; " +
Line 1070: "IFS=''; while read l; do [ \"${l}\" == \"#__EOF__\" ] &&
break || echo \"${l}\" >> \"${MYTMP}/s\"; done; " +
Line 1071: "@ENVIRONMENT@ python \"${MYTMP}/s\"
DIALOG/dialect=str:machine DIALOG/customization=bool:True"
Line 1072: )
--
To view, visit http://gerrit.ovirt.org/17295
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5ddab9ae87979da7d7296c4f3c7ef08e21e903
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
