Martin Betak has posted comments on this change.

Change subject: restapi: Add Test for adding VmPool via REST
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java
Line 34:     }
Line 35: 
Line 36:     @Override
Line 37:     protected org.ovirt.engine.core.common.businessentities.VmPool 
getEntity(int index) {
Line 38:         return 
setUpEntityExpectations(control.createMock(org.ovirt.engine.core.common.businessentities.VmPool.class),
 index);
I took inspiration from the BackendVmsResourceTest and I wanted to maintain 
consistency. Now simplified to minimal framework required by parent 
AbstractBackendCollectionResourceTest.
Line 39:     }
Line 40: 
Line 41:     protected org.ovirt.engine.core.common.businessentities.VmTemplate 
getTemplateEntity(int index) {
Line 42:         return setUpEntityExpectations(


Line 81:         return model;
Line 82:     }
Line 83: 
Line 84:     private VmPool createModel() {
Line 85: 
Done
Line 86:         return getModel(0);
Line 87:     }
Line 88: 
Line 89:     @Test


-- 
To view, visit http://gerrit.ovirt.org/14560
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f91f937bd6302af7f9f96fe7b3c7dfd614c2437
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to