Yair Zaslavsky has posted comments on this change.

Change subject: db: adding default values to ssh fields
......................................................................


Patch Set 2: I would prefer that you didn't submit this

What if I already by mistake added hosts without these "default?
IMHO,
You should add update SQL statements before to handle this.
In addition, please look at common_sp.sql - I know that there is no function to 
handle changing default type, please consult with Eli if we need such function 
, if so - please provide :)

-- 
To view, visit http://gerrit.ovirt.org/17303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae6f434edcacce5039107b221bd86ccaab92309
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to