Sandro Bonazzola has posted comments on this change.
Change subject: [WIP] packaging: setup: additional host support
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File src/plugins/ovirt-hosted-engine-setup/network/firewall_manager.py
Line 230:
Line 231: @plugin.event(
Line 232: stage=plugin.Stages.STAGE_CLOSEUP,
Line 233: condition=lambda self: (
Line 234: self.environment[ohostedcons.NetworkEnv.FIREWALL_MANAGER]
is None
avoiding to break pep8 the best I can do is:
condition=lambda self: (
self.environment[
ohostedcons.NetworkEnv.FIREWALL_MANAGER
] is None and
not self.environment[ohostedcons.CoreEnv.IS_ADDITIONAL_HOST]
),
Line 235: and
Line 236: not
self.environment[ohostedcons.CoreEnv.IS_ADDITIONAL_HOST]
Line 237: ),
Line 238:
--
To view, visit http://gerrit.ovirt.org/17083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbfd842cb54bcb5bea6bd8bbca771202c6a1c2c9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
