Adam Litke has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File mom/Collectors/GuestBalloon.py Line 44: else: Line 45: # filter all the fields that are not exported by this Line 46: # collector Line 47: stat = dict((key, value) for key, value in stat.iteritems() Line 48: if key in self.getFields()) Sorry to be pedantic, but the incompatibility is in the Vdsm Interface so the filtering should be done there (at the same place where you are converting the strings back to ints. Line 49: self.balloon_info_available = True Line 50: -- To view, visit http://gerrit.ovirt.org/17207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74b227a5d945397a69702fc0758d864b33014fc6 Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
