Juan Hernandez has uploaded a new change for review. Change subject: Revert "frontend: Add custom field serializer for RepoImage" ......................................................................
Revert "frontend: Add custom field serializer for RepoImage" This reverts commit 30a941a4b3ed8e46053880a5fd6de325907a9b52, as it was a temporary solution for GWT RPC serialization issues that have been now solved in other patches. Change-Id: I1619f4b1d3b651cdb1a6173d536e5b8ab01e66ca Signed-off-by: Juan Hernandez <[email protected]> --- D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage_CustomFieldSerializer.java 1 file changed, 0 insertions(+), 51 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/17349/1 diff --git a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage_CustomFieldSerializer.java b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage_CustomFieldSerializer.java deleted file mode 100644 index 68bc8bb..0000000 --- a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage_CustomFieldSerializer.java +++ /dev/null @@ -1,51 +0,0 @@ -package org.ovirt.engine.core.common.businessentities; - -import java.util.Date; - -import org.ovirt.engine.core.compat.Guid; - -import com.google.gwt.user.client.rpc.SerializationException; -import com.google.gwt.user.client.rpc.SerializationStreamReader; -import com.google.gwt.user.client.rpc.SerializationStreamWriter; - -/** - * We need this custom field serializer for {@link RepoImage} because otherwise - * the GWT compiler will optimize out some of the fields of the entity and that - * causes exceptions in the standard deserialization mechanism in the server - * side. - */ -public class RepoImage_CustomFieldSerializer { - - public static RepoImage instantiate(SerializationStreamReader reader) throws SerializationException { - return new RepoImage(); - } - - public static void serialize(SerializationStreamWriter writer, RepoImage instance) throws SerializationException { - writer.writeObject(instance.getStoragePoolId()); - writer.writeObject(instance.getStoragePoolStatus()); - writer.writeObject(instance.getVdsStatus()); - writer.writeObject(instance.getRepoDomainId()); - writer.writeObject(instance.getStorageDomainStatus()); - writer.writeString(instance.getRepoImageId()); - writer.writeString(instance.getRepoImageName()); - writer.writeLong(instance.getSize()); - writer.writeObject(instance.getDateCreated()); - writer.writeLong(instance.getLastRefreshed()); - writer.writeObject(instance.getFileType()); - } - - public static void deserialize(SerializationStreamReader reader, RepoImage instance) throws SerializationException { - instance.setStoragePoolId((Guid) reader.readObject()); - instance.setStoragePoolStatus((StoragePoolStatus) reader.readObject()); - instance.setVdsStatus((VDSStatus) reader.readObject()); - instance.setRepoDomainId((Guid) reader.readObject()); - instance.setStorageDomainStatus((StorageDomainStatus) reader.readObject()); - instance.setRepoImageId(reader.readString()); - instance.setRepoImageName(reader.readString()); - instance.setSize(reader.readLong()); - instance.setDateCreated((Date) reader.readObject()); - instance.setLastRefreshed(reader.readLong()); - instance.setFileType((ImageFileType) reader.readObject()); - } - -} -- To view, visit http://gerrit.ovirt.org/17349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1619f4b1d3b651cdb1a6173d536e5b8ab01e66ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
