Eli Mesika has uploaded a new change for review. Change subject: core:[ExternalTasks] When adding new step, type.. ......................................................................
core:[ExternalTasks] When adding new step, type.. [ExternalTasks] When adding new step, type is always EXECUTING Changing AddExternalStepCommand::execute to get the step type from the parameters object instead of using a constant EXECUTING value Change-Id: I04134ffa8e937e623aa7107ca501fb7e79a3ab5c BUG-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988086 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/17375/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java index 95319c5..2dc8395 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java @@ -14,7 +14,6 @@ import org.ovirt.engine.core.common.errors.VdcBllMessages; import org.ovirt.engine.core.common.job.Job; import org.ovirt.engine.core.common.job.Step; -import org.ovirt.engine.core.common.job.StepEnum; import org.ovirt.engine.core.dal.dbbroker.DbFacade; import org.ovirt.engine.core.dao.JobDao; import org.ovirt.engine.core.dao.StepDao; @@ -68,14 +67,14 @@ if (parentStep == null) { // A step that is directly under a job context.setJob(job); context.setExecutionMethod(ExecutionMethod.AsJob); - Step step = ExecutionHandler.addStep(context,StepEnum.EXECUTING, getParameters().getDescription(), true); + Step step = ExecutionHandler.addStep(context, getParameters().getStepType(), getParameters().getDescription(), true); setActionReturnValue(step.getId()); setSucceeded(true); } else {// this is a sub-step context.setStep(parentStep); context.setExecutionMethod(ExecutionMethod.AsStep); - Step step = ExecutionHandler.addSubStep(context, parentStep, StepEnum.EXECUTING, getParameters().getDescription(), true); + Step step = ExecutionHandler.addSubStep(context, parentStep, getParameters().getStepType(), getParameters().getDescription(), true); setActionReturnValue(step.getId()); setSucceeded(true); } -- To view, visit http://gerrit.ovirt.org/17375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I04134ffa8e937e623aa7107ca501fb7e79a3ab5c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
