Allon Mureinik has posted comments on this change.

Change subject: core: Change misleading audit log message.
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 495: USER_REMOVE_VG_FAILED=Failed to remove Volume group ${VgId}. (User: 
UserName)
Line 496: USER_ACTIVATE_STORAGE_POOL=Data Center ${StoragePoolName} was 
activated. (User: ${UserName})
Line 497: USER_ACTIVATE_STORAGE_POOL_FAILED=Failed to activate Data Center 
${StoragePoolName}. (User: ${UserName})
Line 498: SYSTEM_FAILED_CHANGE_STORAGE_POOL_STATUS=Failed to change Data Center 
${StoragePoolName} status.
Line 499: SYSTEM_CHANGE_STORAGE_POOL_STATUS_NO_HOST_FOR_SPM=Fencing failed on 
Storage Pool Manager for Data Center ${StoragePoolName}. Setting status to 
Non-Operational.
Can we add the hostname here?
Line 500: SYSTEM_CHANGE_STORAGE_POOL_STATUS_PROBLEMATIC=Invalid status on Data 
Center ${StoragePoolName}. Setting status to Non Responsive.
Line 501: SYSTEM_CHANGE_STORAGE_POOL_STATUS_RESET_IRS=Data Center 
${StoragePoolName} was reset. Setting status to Non Responsive (Elect new 
Storage Pool Manager).
Line 502: 
SYSTEM_CHANGE_STORAGE_POOL_STATUS_PROBLEMATIC_FROM_NON_OPERATIONAL=Try to 
recover Data Center ${StoragePoolName}. Setting status to Non Responsive.
Line 503: SYSTEM_CHANGE_STORAGE_POOL_STATUS_PROBLEMATIC_SEARCHING_NEW_SPM=Data 
Center is being initialized, please wait for initialization to complete.


....................................................
Commit Message
Line 12: Changing text to: "Fencing failed on Storage Pool Manager for
Line 13: Data Center ${StoragePoolName}. Setting status to Non-Operational."
Line 14: 
Line 15: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=954301
Line 16: 
Please remove the blank line here, it breaks all sorts of scripts.
Line 17: Change-Id: Ib3653ed1ac9dae8779c2abfe788d4aafaa48ed28


-- 
To view, visit http://gerrit.ovirt.org/17407
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3653ed1ac9dae8779c2abfe788d4aafaa48ed28
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to