Allon Mureinik has posted comments on this change.
Change subject: core: add GetImageByIdQuery
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
See questions inline.
The major one is the permissions one.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParameters.java
Line 5:
Line 6:
Line 7: public class GetImagesListParameters extends
GetImagesListParametersBase {
Line 8:
Line 9: private static final long serialVersionUID = -6108007966929358776L;
why?
Line 10:
Line 11: public GetImagesListParameters() {
Line 12: }
Line 13:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
Line 85: // VM Snapshot queries
Line 86: GetAllVmSnapshotsByVmId(VdcQueryAuthType.User),
Line 87:
Line 88: // Images queries
Line 89: GetImageById(VdcQueryAuthType.User),
How is this OK permissions-wise?
Line 90: GetImagesList(VdcQueryAuthType.User),
Line 91: GetImagesListByStoragePoolId(VdcQueryAuthType.User),
Line 92: GetAllDisksByVmId(VdcQueryAuthType.User),
Line 93: GetAllAttachableDisks(VdcQueryAuthType.User),
--
To view, visit http://gerrit.ovirt.org/17346
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53f05023301df81fc66d4ff36bc98369ae15a3f7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
