Liron Ar has posted comments on this change.
Change subject: core, restapi: wip: Introducing hot plug disk snapshot support
......................................................................
Patch Set 2: Fails
(2 inline comments)
Pending related vdsm changes to avoid snapshot corruption..INCOMPLETE.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResourceTest.java
Line 155: protected UriInfo setUpTryBackExpectations() {
Line 156: return setUpActionExpectations(
Line 157: VdcActionType.TryBackToAllSnapshotsOfVm,
Line 158: TryBackToAllSnapshotsOfVmParameters.class,
Line 159: new String[] { "VmId", "SnapshotId", "DiskId" },
unrelated changed, would be removed.
Line 160: new Object[] { VM_ID, SNAPSHOT_ID },
Line 161: true,
Line 162: true,
Line 163: null,
....................................................
File packaging/dbscripts/disk_images_sp.sql
Line 127:
Line 128:
Line 129:
Line 130: Create or replace FUNCTION
GetDiskSnapshotForVmSnapshot(v_image_group_id UUID, v_vm_snapshot_id UUID)
Line 131: RETURNS SETOF images_storage_domain_view
would be replaced by spaces..IDE formatting
Line 132: AS $procedure$
Line 133: BEGIN
Line 134: RETURN QUERY SELECT *
Line 135: FROM images_storage_domain_view
images_storage_domain_view
--
To view, visit http://gerrit.ovirt.org/17420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1a265438dc5bc2d887a88a9be12641c721d9735
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
