Michael Pasternak has posted comments on this change.
Change subject: restapi: cloud-init [6/6] - rest api for start vm
......................................................................
Patch Set 13: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 594: <xs:element ref="watchdog_actions" minOccurs="0"/>
Line 595: <xs:element ref="authentication_methods" minOccurs="0"/>
Line 596: <!-- Extrenal tasks -->
Line 597: <xs:element ref="step_types" minOccurs="0"/>
Line 598: <xs:element ref="payload_encodings" minOccurs="0"/>
why do you need a enaum for this? you can fetch this at runtime directly from
the string ....
Line 599:
Line 600: <!-- Gluster related -->
Line 601: <xs:element ref="gluster_volume_types" minOccurs="0"/>
Line 602: <xs:element ref="transport_types" minOccurs="0"/>
Line 2208: </xs:annotation>
Line 2209: </xs:element>
Line 2210: </xs:sequence>
Line 2211: </xs:complexType>
Line 2212:
i had a lot of comments in the Patch Set 1, please address them.
Line 2213: <xs:complexType name="CloudInit">
Line 2214: <xs:sequence>
Line 2215: <xs:element name="hostname" type="xs:string" minOccurs="0"/>
Line 2216: <xs:element name="network" minOccurs="0">
Line 2311: <xs:element name="initialization" type="Initialization"/>
Line 2312:
Line 2313: <xs:complexType name="Initialization">
Line 2314: <xs:choice>
Line 2315: <xs:element name="cloud-init" type="CloudInit" minOccurs="0"/>
name should be cloud_init
Line 2316: </xs:choice>
Line 2317: </xs:complexType>
Line 2318:
Line 2319: <xs:complexType name="VmPlacementPolicy">
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 505: if (vm.isSetInitialization()) {
Line 506: if (vm.getInitialization().isSetCloudInit()) {
Line 507:
params.setCloudInitParameters(map(vm.getInitialization().getCloudInit(), null));
Line 508: }
Line 509: }
please add test in VmMapeerTest
Line 510:
Line 511: return params;
Line 512: }
Line 513:
....................................................
Commit Message
Line 11: Further details available at:
Line 12: http://www.ovirt.org/Features/Cloud-Init_Integration
Line 13:
Line 14: This patch adds support for specifying Cloud-Init configuration when
Line 15: starting a VM using the REST API.
please describe this feature in the FeaturesHelper
Line 16:
Line 17: Change-Id: I6ad0bfeca23cf8d4b2887010081d63c258032611
--
To view, visit http://gerrit.ovirt.org/15537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ad0bfeca23cf8d4b2887010081d63c258032611
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
