Laszlo Hornyak has posted comments on this change.
Change subject: Add make file
......................................................................
Patch Set 1: (4 inline comments)
let's just split into two
....................................................
File Makefile
Line 1: all: test pep8
Line 2:
Line 3: test:
Line 4: make start
here we should keep the nosetests, but also run the java tests
Line 5: cd tests/java && mvn clean install
Line 6: make stop
Line 7:
Line 8: pep8:
Line 7:
Line 8: pep8:
Line 9: pep8 src
Line 10: start:
Line 11: python src/oschedproxyd.py &
this looks ok to me, I hope the linux guys have nothing against it
Line 12: stop:
....................................................
File src/oschedproxyd.py
Line 71:
Line 72: # TODO make by config
Line 73: logging.info("Loading modules")
Line 74: self._handler = RequestHandler(
Line 75: os.path.join(os.getcwd() + "/plugins"),
this modification needs to be moved to another patch and also the / from the
"/plugins" is not needed there afaik
Line 76: os.getcwd() + "/src"
Line 77: )
Line 78:
Line 79: def run(self):
Line 72: # TODO make by config
Line 73: logging.info("Loading modules")
Line 74: self._handler = RequestHandler(
Line 75: os.path.join(os.getcwd() + "/plugins"),
Line 76: os.getcwd() + "/src"
should use os.path.join and without /
Line 77: )
Line 78:
Line 79: def run(self):
Line 80: logging.info("Running server")
--
To view, visit http://gerrit.ovirt.org/17424
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34e025773eb92865c770adf164c20d3b907e84d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
