Moti Asayag has posted comments on this change. Change subject: core: sort vm nics before returning them ......................................................................
Patch Set 1: I would prefer that you didn't submit this The nics are ordered according to the mac address field. A comparator is already applied to the vnics on the dao level. See backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java by using InterfaceComparerByMAC. However, since the template's vnics has no mac address, it is reasonable to apply an order to them by name. I'll have to dig dipper in order to find the bug which required the order of vm's nics by the mac address. -- To view, visit http://gerrit.ovirt.org/17313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39f4638a0d312ad5188ca4758427cea7cfc1d8e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
