Michael Pasternak has posted comments on this change. Change subject: core:[ExternalTasks] Cannot add sub-step under... ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java Line 52: Response response = performCreate(VdcActionType.AddExternalStep, Line 53: new AddExternalStepParameters(asGuid(id), step.getDescription(),StepMapper.map(StepEnum.fromValue(step.getType())), JobMapper.map(step.getStatus(), null)), Line 54: new QueryIdResolver<Guid>(VdcQueryType.GetStepByStepId, IdQueryParameters.class)); Line 55: Step createdStep = (Step)response.getEntity(); Line 56: injectParent(createdStep); the right way to fix this is: 1. leave this code as is 2. override map() 3. in map() call supper.map() and than injectParent(); (does this is relevant for update as well?) Line 57: return response; Line 58: } Line 59: Line 60: @Override -- To view, visit http://gerrit.ovirt.org/17488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc610d6f295a688ceec1b038107c07d43390b431 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
