Ravi Nori has posted comments on this change.
Change subject: [WIP] Introduce new directory interface
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File backend/manager/modules/auth/pom.xml
Line 29: <dependency>
Line 30: <groupId>log4j</groupId>
Line 31: <artifactId>log4j</artifactId>
Line 32: </dependency>
Line 33:
please remove extra spaces
Line 34: <dependency>
Line 35: <groupId>commons-codec</groupId>
Line 36: <artifactId>commons-codec</artifactId>
Line 37: </dependency>
....................................................
File
backend/manager/modules/auth/src/main/java/org/ovirt/engine/core/directory/DirectoryManager.java
Line 176: return null;
Line 177: }
Line 178:
Line 179: // Actually load the directory from the configuration:
Line 180: return loadInstance(file, configuration);
A longer more descriptive name would be helpful
Line 181: }
Line 182:
Line 183: /**
Line 184: * Loads a directory service instance from a set of properties.
....................................................
File
backend/manager/modules/auth/src/main/java/org/ovirt/engine/core/directory/DirectoryUser.java
Line 114: return true;
Line 115: }
Line 116: if (obj == null) {
Line 117: return false;
Line 118: }
Should the null check be the first if statement?
Line 119: if (getClass() != obj.getClass()) {
Line 120: return false;
Line 121: }
Line 122: if (!super.equals(obj)) {
--
To view, visit http://gerrit.ovirt.org/15596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If84a0c9d6553d81cdbbe224972696f169cca90d4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
