Juan Hernandez has posted comments on this change. Change subject: [WIP] Add internal directory provider ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/auth/src/main/java/org/ovirt/engine/core/directory/internal/InternalDirectory.java Line 21: // The identifier of the admin user of the internal directory is inserted Line 22: // in the database when it is created, we need to use exactly the same here: Line 23: private static final String ADMIN_GUID = Line 24: "fdfc627c-d875-11e0-90f0-83df133b58cc"; Line 25: I don't see any benefit in making this identifier configurable (same for AdminUser and AdminDomain). In addition the same constant is used in the SQL scritps during database creation, so if we make it configurable and the user happens to change the permissions for this user will stop working. Line 26: // This is the only user of this directory: Line 27: private final DirectoryUser admin = new DirectoryUser( Line 28: this, Line 29: ADMIN_GUID, -- To view, visit http://gerrit.ovirt.org/15601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f4e7db1b42ded74f611a9453b3db229c6d069d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
