Vojtech Szocs has uploaded a new change for review. Change subject: frontend: Fix SearchableListModel.getSearchString() ......................................................................
frontend: Fix SearchableListModel.getSearchString() Commit caef3ae [frontend: Add paging in SubTabPoolVmView] has modified SearchableListModel.getSearchString() implementation so that it returns "null" (String) instead of null (literal) when searchString field is null. In practice, GUI bound to SearchableListModel.searchString via GWT Editor framework now shows "null" (String) instead of empty string (due to null literal) when searchString field is null, for example: Data Center main tab | Permission sub tab | Add button -> text box left to "GO" button now shows "null" string This patch fixes the above mentioned problem by ensuring getSearchString() returns null (instead of "null") when searchString field is null. Change-Id: I2fc2cab5785597cd7a7c9602a967250f16742489 Signed-off-by: Vojtech Szocs <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/17504/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java index c013fe8..89b1443 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java @@ -184,6 +184,10 @@ public String getSearchString() { + // pagingSearchString is relevant only for non-null searchString + if (searchString == null) { + return null; + } return searchString + (pagingSearchString == null ? "" : pagingSearchString); } -- To view, visit http://gerrit.ovirt.org/17504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2fc2cab5785597cd7a7c9602a967250f16742489 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
