Alon Bar-Lev has uploaded a new change for review.

Change subject: packaging: services: ovirt-engine: support space within java 
properties
......................................................................

packaging: services: ovirt-engine: support space within java properties

Change-Id: I0dfb09391ae5d3c92de4ce97e29b60a73135cbcd
Signed-off-by: Alon Bar-Lev <[email protected]>
---
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/services/ovirt-engine/ovirt-engine.py
2 files changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/17505/1

diff --git a/packaging/services/ovirt-engine/ovirt-engine.conf.in 
b/packaging/services/ovirt-engine/ovirt-engine.conf.in
index 4d1f2b6..3cc7e24 100644
--- a/packaging/services/ovirt-engine/ovirt-engine.conf.in
+++ b/packaging/services/ovirt-engine/ovirt-engine.conf.in
@@ -101,7 +101,8 @@
 #
 #   -Dmy.param=my.value -Dmy.flag -Dyour.param=your.value
 #
-ENGINE_PROPERTIES=jsse.enableSNIExtension=false
+ENGINE_PROPERTIES=""
+ENGINE_PROPERTIES="${ENGINE_PROPERTIES} jsse.enableSNIExtension=false"
 
 #
 # Additional applications to be deployed in the instance of the
diff --git a/packaging/services/ovirt-engine/ovirt-engine.py 
b/packaging/services/ovirt-engine/ovirt-engine.py
index 3b78f2c..45789cc 100755
--- a/packaging/services/ovirt-engine/ovirt-engine.py
+++ b/packaging/services/ovirt-engine/ovirt-engine.py
@@ -19,6 +19,7 @@
 import os
 import sys
 import re
+import shlex
 import gettext
 _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine')
 
@@ -345,8 +346,9 @@
         ])
 
         # Add extra system properties provided in the configuration:
-        engineProperties = self._config.get('ENGINE_PROPERTIES')
-        for engineProperty in engineProperties.split():
+        for engineProperty in shlex.split(
+            self._config.get('ENGINE_PROPERTIES')
+        ):
             if not engineProperty.startswith('-D'):
                 engineProperty = '-D' + engineProperty
             self._engineArgs.append(engineProperty)


-- 
To view, visit http://gerrit.ovirt.org/17505
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dfb09391ae5d3c92de4ce97e29b60a73135cbcd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to