Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Add an uninstall file at closeup ......................................................................
Patch Set 1: I would prefer that you didn't submit this If I've understood correctly, closeup stage is not reached if something goes wrong during previous stages while cleanup is always reached. We have some changes that will not be rolled back if the failure is at misc stage (like postgresql provisioning, pki certificates,...). So I think that we should always create the uninstall file allowing the user to cleanup the changes after a failure. -- To view, visit http://gerrit.ovirt.org/17493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44e87a41ec6f7b9f395a78b5dbc7f9ac3c8350f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
