Eli Mesika has posted comments on this change. Change subject: history: resynced the create db scripts ......................................................................
Patch Set 2: (3 inline comments) I will try to push http://gerrit.ovirt.org/#/c/17399/ ASAP After that, this patch should include the relevant override of the relevant MV functions in dbcustomfunctions.sh .................................................... File data-warehouse/historydbscripts_postgres/create_db.sh Line 35: s) SERVERNAME=$OPTARG;; Line 36: p) PORT=$OPTARG;; Line 37: d) DATABASE=$OPTARG;; Line 38: u) USERNAME=$OPTARG;; Line 39: l) LOGFILE=$OPTARG;; Please remove leading TAB Line 40: m) MD5DIR=$OPTARG;; Line 41: g) NOMD5=true;; Line 42: v) VERBOSE=true;; Line 43: h) ret=0 && usage;; .................................................... File data-warehouse/historydbscripts_postgres/refreshStoredProcedures.sh Line 31: case $option in Line 32: s) SERVERNAME=$OPTARG;; Line 33: d) DATABASE=$OPTARG;; Line 34: u) USERNAME=$OPTARG;; Line 35: l) LOGFILE=$OPTARG;; Please remove TAB Line 36: v) VERBOSE=true;; Line 37: h) ret=0 && usage;; Line 38: \?) ret=1 && usage;; Line 39: esac .................................................... File data-warehouse/historydbscripts_postgres/upgrade/03_01_0000_set_version.sql Line 1: -- This is just a dummy command to init the right version in DB Line 2: select 1; Should set the version to 3.1 as in the original script -- To view, visit http://gerrit.ovirt.org/17378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51cf70991aae6318d27d4c8475194d7f8c4c0686 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
