Doron Fediuck has posted comments on this change.
Change subject: [wip] engine: external scheduler integration
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 182: messages,
Line 183: memoryChecker);
Line 184:
Line 185: // filter the hosts through external filters as last step
in filtering
Line 186: vdsList =
Please skip this part if base on config.
Line 187: runExternalFilters(vdsList,
Line 188: parameters, messages);
Line 189:
Line 190: if (vdsList == null || vdsList.size() == 0) {
Line 240: messages,
Line 241: noWaitingMemoryChecker);
Line 242:
Line 243: // after running the internal filters, run the external
filters
Line 244: vdsList =
Please skip this part if base on config.
Line 245: runExternalFilters(vdsList,
Line 246: parameters,
Line 247: messages);
Line 248:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1451:
Line 1452: @TypeConverterAttribute(String.class)
Line 1453: @DefaultValueAttribute("http://localhost:18781/";)
Line 1454: ExternalSchedulerServiceURL(523),
Line 1455:
please fix white spaces here and below.
Also, default must be empty string.
Line 1456: @TypeConverterAttribute(Integer.class)
Line 1457: @DefaultValueAttribute("100")
Line 1458: ExternalSchedulerConnectionTimeout(523),
Line 1459:
Line 1458: ExternalSchedulerConnectionTimeout(523),
Line 1459:
Line 1460: @TypeConverterAttribute(Boolean.class)
Line 1461: @DefaultValueAttribute("false")
Line 1462: ExternalSchedulerBehavior(523),
Why is it behavior?
Maybe UseExternalScheduler?
Line 1463:
Line 1464: Invalid(65535);
Line 1465:
Line 1466: private int intValue;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
Line 762:
ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_DATA(ErrorType.BAD_PARAMETERS),
Line 763:
ACTION_TYPE_FAILED_NETWORK_QOS_NOT_FOUND(ErrorType.BAD_PARAMETERS),
Line 764:
ACTION_TYPE_FAILED_NETWORK_QOS_INVALID_DC_ID(ErrorType.BAD_PARAMETERS),
Line 765:
ACTION_TYPE_FAILED_NETWORK_QOS_PEAK_LOWER_THAN_AVERAGE(ErrorType.BAD_PARAMETERS),
Line 766:
white space.
Line 767: //exteral scheduler
Line 768: EXTERNAL_SCHEDULER_FAIL(ErrorType.INTERNAL_ERROR),
Line 769:
Line 770: // memory QOS features
....................................................
Commit Message
Line 5: CommitDate: 2013-07-30 18:15:16 +0200
Line 6:
Line 7: [wip] engine: external scheduler integration
Line 8:
Line 9: external scheduler integration
Please elaborate.
Explain how it works, API, etc.
Line 10:
Line 11: Change-Id: I95b6660beb319df0afe569f31c16033bf6192df9
--
To view, visit http://gerrit.ovirt.org/17501
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95b6660beb319df0afe569f31c16033bf6192df9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
