Alissa Bonas has posted comments on this change.
Change subject: core: Removing a storage connection without a VDS
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommandTest.java
Line 237: parameters.setStorageServerConnection(NFSConnection);
Line 238: parameters.setVdsId(Guid.Empty);
Line 239:
doNothing().when(storageServerConnectionDAO).remove(NFSConnection.getid());
Line 240: // Test will fail if we try to disconnect
Line 241: command.executeCommand();
I suggest to add validation that disconnect method is never called, but it's up
to you.
Line 242: }
Line 243:
Line 244: @Test
Line 245: public void checkExecuteCommandWithNullVdsId() {
Line 246: parameters.setStorageServerConnection(NFSConnection);
Line 247: parameters.setVdsId(null);
Line 248:
doNothing().when(storageServerConnectionDAO).remove(NFSConnection.getid());
Line 249: // Test will fail if we try to disconnect
Line 250: command.executeCommand();
I suggest to add validation that disconnect method is never called, but it's up
to you.
Line 251: }
--
To view, visit http://gerrit.ovirt.org/17531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ddcf6cb6cd2aed85c23f0e7565ab0b597474a81
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
