Yair Zaslavsky has posted comments on this change.
Change subject: core: fix storage pool ID association with tasks
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
Line 174: public void update(AsyncTasks task) {
Line 175: logNullParameters(task);
Line 176:
Line 177: AsyncTaskParameterSource parameterSource =
getTaskParameterSource(task);
Line 178: parameterSource.addValue("storage_pool_id",
task.getStoragePoolId());
yes, parameters order as passed to stored procedures.
This can be fixed in a different patch.
Update does not need all the parameters, for example - start time should not be
passed to update.
Line 179: getCallsHandler().executeModification("Updateasync_tasks",
parameterSource);
Line 180: }
Line 181:
Line 182: private static void logNullParameters(AsyncTasks task) {
--
To view, visit http://gerrit.ovirt.org/17532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8f06e7c3b16504f76f6188f3d99fa5e80eedd4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
