Yair Zaslavsky has posted comments on this change.
Change subject: core: [ExternalTasks] Cannot end existing job
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 391:
Line 392: private boolean isActionExternal(VdcActionType actionType){
Line 393: return (actionType == VdcActionType.EndExternalJob ||
actionType == VdcActionType.EndExternalStep || actionType ==
VdcActionType.ClearExternalJob);
Line 394: }
Line 395: protected VdcReturnValueBase runAction(CommandBase<?> command,
add a single enter between isActionExternal and runAction, and merge.
Line 396: boolean runAsInternal,
Line 397: CommandContext context) {
Line 398: VdcReturnValueBase returnValue =
evaluateCorrelationId(command);
Line 399: if (returnValue != null) {
--
To view, visit http://gerrit.ovirt.org/17495
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f72cd619e32e5763f46391932ec70730a2b4b7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
