Alissa Bonas has uploaded a new change for review. Change subject: core: remove unnecessary allocation of Guid ......................................................................
core: remove unnecessary allocation of Guid Remove unnecessary allocation and cloning of Guid when assigning id values to objects. Removed cloning in 2 places, in third place its usage was in unused method, so removed the method. Change-Id: I857b4fe7ad1f1dcff486e489e262441823a6cb3e Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java 3 files changed, 5 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/17540/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java index 3a41f0c..e4277e0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java @@ -88,7 +88,7 @@ @Override public VdcActionParametersBase doWith(final StorageDomain arg) { final StorageDomainPoolParametersBase params = new StorageDomainPoolParametersBase( - arg.getId(), new Guid(arg.getStoragePoolId().getUuid())); + arg.getId(), arg.getStoragePoolId()); params.setRunSilent(true); return params; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java index d8f01cc..5aad0a5 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java @@ -371,10 +371,10 @@ di.flushLatency = diskImage.flushLatency; // string is immutable, so no need to deep copy it di.description = diskImage.description; - di.setImageId(new Guid(diskImage.getImageId().getUuid())); + di.setImageId(diskImage.getImageId()); di.appList = diskImage.appList; - di.setImageTemplateId(new Guid(diskImage.getImageTemplateId().getUuid())); - di.setParentId(new Guid(diskImage.getParentId().getUuid())); + di.setImageTemplateId(diskImage.getImageTemplateId()); + di.setParentId(diskImage.getParentId()); di.setImageStatus(diskImage.getImageStatus()); di.setLastModified(new Date(diskImage.getLastModified().getTime())); di.storageIds = new ArrayList<Guid>(diskImage.storageIds); @@ -388,7 +388,7 @@ di.setDiskAlias(diskImage.getDiskAlias()); di.setDiskDescription(diskImage.getDiskDescription()); di.setShareable(diskImage.isShareable()); - di.storagePoolId = new Guid(diskImage.storagePoolId.getUuid()); + di.storagePoolId = diskImage.storagePoolId; di.actualSize = diskImage.actualSize; di.readRateKbPerSec = diskImage.readRateKbPerSec; di.writeRateKbPerSec = diskImage.writeRateKbPerSec; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java index c82c9b0..14f4804 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java @@ -59,13 +59,6 @@ return availableDiskSize; } - public static StorageDomainDynamic copyOf(StorageDomainDynamic domain) { - StorageDomainDynamic sdd = new StorageDomainDynamic(); - sdd.availableDiskSize = domain.availableDiskSize; - sdd.id = new Guid(domain.id.getUuid()); - sdd.usedDiskSize = domain.usedDiskSize; - return sdd; - } @Override public int hashCode() { -- To view, visit http://gerrit.ovirt.org/17540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I857b4fe7ad1f1dcff486e489e262441823a6cb3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
