Greg Padgett has posted comments on this change. Change subject: packaging: setup: confirm admin password ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Just a minor nit .................................................... File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py Line 233: else: Line 234: password_check = self.dialog.queryString( Line 235: name='ENGINE_ADMIN_PASSWORD', Line 236: note=_( Line 237: "Confirm 'admin@internal' user password : " extra space before colon Line 238: ), Line 239: prompt=True, Line 240: hidden=True, Line 241: ) -- To view, visit http://gerrit.ovirt.org/17538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idabd7eb56440e02462407007375fbaf113430adf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
