Itamar Heim has posted comments on this change.
Change subject: core: Create virtio-scsi controller when needed
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 230: }
Line 231:
Line 232: @Override
Line 233: protected void buildVmDrives() {
Line 234: boolean containsVirtioScsiDisk = false;
if there is an issue with scsi disks in ppc, we could make this relevant only
to guest OSs which allow a virtio-scsi disk at all. the ppc arch OSs would not
allow it, etc.?
(assuming i understand the problem correctly and ppc don't support virtio-scsi)
Line 235: List<Disk> disks = getSortedDisks();
Line 236: for (Disk disk : disks) {
Line 237: Map<String, Object> struct = new HashMap<String,
Object>();
Line 238: // get vm device for this disk from DB
--
To view, visit http://gerrit.ovirt.org/17526
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife8978c117a6b33a7fb71a3633843f5926b502b8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
