Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
......................................................................
Patch Set 15: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
Line 48: if (vds.getHostOs().indexOf("oVirt Node") != -1) {
Line 49: node = "ovirt-node-iso";
Line 50: } else {
Line 51: node = "rhev-hypervisor";
Line 52: }
hard code this is very bad! we should add this to the configuration.
Line 53:
Line 54: RpmVersion vdsOsVersion =
VdsHandler.getOvirtHostOsVersion(vds);
Line 55:
Line 56: for (OVirtNodeInfo.Entry info :
OVirtNodeInfo.getInstance().get()) {
Line 53:
Line 54: RpmVersion vdsOsVersion =
VdsHandler.getOvirtHostOsVersion(vds);
Line 55:
Line 56: for (OVirtNodeInfo.Entry info :
OVirtNodeInfo.getInstance().get()) {
Line 57: if (info.path.getAbsolutePath().indexOf(node) != -1 &&
info.path.isDirectory()) {
not only the file name?
Line 58: log.debugFormat("Looking for list of ISOs in [{0}]",
info.path);
Line 59: log.debugFormat("regex pattern for ISOs: [{0}]",
info.pattern);
Line 60: for (File file : info.path.listFiles()) {
Line 61: Matcher matcher =
info.pattern.matcher(file.getName());
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 368: select
fn_db_add_config_value('OvfVirtualSystemType','ENGINE','general');
Line 369: --Handling The ovirt-node installation files path
Line 370: select
fn_db_add_config_value('OvirtInitialSupportedIsoVersion','2.5.5:5.8','general');
Line 371: select
fn_db_add_config_value('OvirtIsoPrefix','^ovirt-node-iso-(.*)\.*\.iso$:^rhevh-(.*)\.*\.iso$','general');
Line 372: select
fn_db_add_config_value('oVirtISOsRepositoryPath','/usr/share/ovirt-node-iso:/usr/share/rhev-hypervisor','general');
I suggest to add node os here, a new parameter which is regular expression, to
drop the hard coded.
Line 373: select
fn_db_add_config_value('oVirtUpgradeScriptName','/usr/share/vdsm-reg/vdsm-upgrade','general');
Line 374: select
fn_db_add_config_value('oVirtUploadPath','/data/updates/ovirt-node-image.iso','general');
Line 375: select
fn_db_add_config_value('OvfUpdateIntervalInMinutes','60','general');
Line 376: select
fn_db_add_config_value('OvfItemsCountPerUpdate','100','general');
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
