Alex Lourie has posted comments on this change.
Change subject: packaging: setup: avoid endless loop when setVmTicket fails
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Minor text comment
....................................................
File src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
Line 79: 'You can now connect to the VM with the following
command:\n'
Line 80: '\t{remote} --spice-ca-file={ca_cert} '
Line 81: 'spice://localhost?tls-port=5900 '
Line 82: '--spice-host-subject="{subject}"\nUse temporary
password '
Line 83: '"{password}" to connect to vnc console.'
is it VNC? Maybe use more generic term, such as 'graphical screen' or something?
Line 84: ).format(
Line 85: remote=self.command.get('remote-viewer'),
Line 86: ca_cert=ohostedcons.FileLocations.LIBVIRT_CA_CERT,
Line 87:
subject=self.environment[ohostedcons.VDSMEnv.SPICE_SUBJECT],
--
To view, visit http://gerrit.ovirt.org/17539
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I664fb5ce7620bda4f8e8d6d46a0b024aecae149a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
