Alon Bar-Lev has posted comments on this change.
Change subject: core: Provide a wrapper script with ovirt to...
......................................................................
Patch Set 6:
1. Why is this in dbutils and not in dbscripts or tools? if tools, please move
to bin.
2. You should not hard code paths... if this is tools you can just source
enigne-prolog.sh and have access to "${ENGINE_VAR}"
3. You need to create this directory in spec file, again, I suggest to move
this to tools package.
--
To view, visit http://gerrit.ovirt.org/16273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I468f830196bd95dc013a5142f9aa0d508e687d90
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
