Mike Kolesnik has posted comments on this change.
Change subject: engine: Support vnic api by network name for backward
compatibility
......................................................................
Patch Set 3:
(3 comments)
Basically looks good, just small comments about the message & some method name
which can be fixed later
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
Line 215: iface.setVnicProfileId(vnicProfile.getId());
Line 216: return true;
Line 217: }
Line 218:
Line 219: public ValidationResult
updateParametersForBackwardCompatibility(VmNetworkInterface nic, VmBase vm,
Guid userId) {
Probably Parameters isn't what you were looking for in this context, maybe just
nic?
Line 220: if (nic.getVnicProfileId() != null) {
Line 221: return ValidationResult.VALID;
Line 222: }
Line 223:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 367: VNIC_PROFILE_NAME_IN_USE=Cannot ${action} ${type}. The VM network
interface profile's name is already used by an existing profile in the same
data-center.\n-Please choose a different name.
Line 368: VNIC_PROFILE_IN_USE=Cannot ${action} ${type}. Several ${entities}
(${ENTITIES_USING_VNIC_PROFILE_COUNTER}) are using this VM network interface
profile:\n${ENTITIES_USING_VNIC_PROFILE}\n - Please remove it from all
${entities} that are using it and try again.
Line 369: CANNOT_CHANGE_VNIC_PROFILE_NETWORK=Cannot ${action} ${type}. VM
network interface profile's network cannot be changed.
Line 370: CANNOT_ADD_VNIC_PROFILE_TO_NON_VM_NETWORK=Cannot ${action} ${type}.
VM network interface profiles can be added to a VM network only.
Line 371: ACTION_TYPE_FAILED_CANNOT_FIND_VNIC_PROFILE_FOR_NETWORK=Cannot
${action} ${type}. There is no VM network interface's profile for the network
the user can use.\n\
The "'s" is not syntactically correct and can be omitted..
Also why you need \n if you break line anyway?
Line 372: -Please use VM network interface profile instead of network name.
Line 373: ACTION_TYPE_FAILED_NAME_ALREADY_USED=Cannot ${action} ${type}. The
${type} name is already in use, please choose a unique name and try again.
Line 374: VALIDATION_VDS_CONSOLEADDRESSS_HOSTNAME_OR_IP=Console address must be
a FQDN or a valid IP address
Line 375: ACTION_TYPE_FAILED_URL_INVALID=Cannot ${action} ${type}. The URL is
not valid, please enter a valid URL and try again.
Line 368: VNIC_PROFILE_IN_USE=Cannot ${action} ${type}. Several ${entities}
(${ENTITIES_USING_VNIC_PROFILE_COUNTER}) are using this VM network interface
profile:\n${ENTITIES_USING_VNIC_PROFILE}\n - Please remove it from all
${entities} that are using it and try again.
Line 369: CANNOT_CHANGE_VNIC_PROFILE_NETWORK=Cannot ${action} ${type}. VM
network interface profile's network cannot be changed.
Line 370: CANNOT_ADD_VNIC_PROFILE_TO_NON_VM_NETWORK=Cannot ${action} ${type}.
VM network interface profiles can be added to a VM network only.
Line 371: ACTION_TYPE_FAILED_CANNOT_FIND_VNIC_PROFILE_FOR_NETWORK=Cannot
${action} ${type}. There is no VM network interface's profile for the network
the user can use.\n\
Line 372: -Please use VM network interface profile instead of network name.
There should be an "a" before VM and probably also before "network name".
Also after - there should be a space?
Line 373: ACTION_TYPE_FAILED_NAME_ALREADY_USED=Cannot ${action} ${type}. The
${type} name is already in use, please choose a unique name and try again.
Line 374: VALIDATION_VDS_CONSOLEADDRESSS_HOSTNAME_OR_IP=Console address must be
a FQDN or a valid IP address
Line 375: ACTION_TYPE_FAILED_URL_INVALID=Cannot ${action} ${type}. The URL is
not valid, please enter a valid URL and try again.
Line 376: ACTION_TYPE_FAILED_STORAGE_CONNECTION_NOT_EXIST=Cannot ${action}
${type}. Storage connection doesn't exist.
--
To view, visit http://gerrit.ovirt.org/17615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70843c967981567fa83613d3e9576640bcd8b7d5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
