Allon Mureinik has posted comments on this change. Change subject: core: call connectStorageServer when add a domain ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java Line 124: VdcReturnValueBase result = null; Line 125: String connectionId = getStorageDomain().getStorage(); Line 126: StorageServerConnections connection = getStorageServerConnectionDAO().get(connectionId); Line 127: result = Backend.getInstance().runInternalAction(VdcActionType.ConnectStorageToVds, Line 128: new StorageServerConnectionParametersBase(connection, getParameters().getVdsId())); why not use org.ovirt.engine.core.bll.storage.StorageHelperBase#connectStorageToDomainByVdsId ? Line 129: return result; Line 130: Line 131: } Line 132: -- To view, visit http://gerrit.ovirt.org/17680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93e681a36f439277054bf22d8ecb319e330d14f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
