Sandro Bonazzola has posted comments on this change. Change subject: ovirt-live: migrate ovirt live plugin to otopi ......................................................................
Patch Set 9: Code-Review-1 (3 comments) .................................................... File fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py Line 61: Line 62: @plugin.event( Line 63: stage=plugin.Stages.VALIDATION, Line 64: ) Line 65: def _init(self): you're redefining _init here: use _validation Line 66: import ovirtsdk.api Line 67: from ovirtsdk.xml import params Line 68: self._ovirtsdk_api = ovirtsdk.api Line 69: self._ovirtsdk_xml = ovirtsdk.xml Line 67: from ovirtsdk.xml import params Line 68: self._ovirtsdk_api = ovirtsdk.api Line 69: self._ovirtsdk_xml = ovirtsdk.xml Line 70: Line 71: @plugin.event( minor comment, I would have moved the _setup method before the _validation. Line 72: stage=plugin.Stages.STAGE_SETUP, Line 73: condition=lambda self: self.environment[ Line 74: oliveconst.CoreEnv.ENABLE Line 75: ], Line 121: oliveconst.ConfigEnv.DEFAULT_ISO_NAME, Line 122: ], Line 123: ), Line 124: ) Line 125: use only one new line here Line 126: Line 127: @plugin.event( Line 128: stage=plugin.Stages.CLOSEUP, Line 129: condition=lambda self: self._enabled, -- To view, visit http://gerrit.ovirt.org/17518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703f64dc1183a6fe176d9d0352f93de381d906bb Gerrit-PatchSet: 9 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
