Allon Mureinik has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 196: private boolean connectHostToPool() {
Line 197: final VDS vds = getVds();
Line 198: EventResult result =
Line 199: ((EventQueue)
EjbUtils.findBean(BeanType.EVENTQUEUE_MANAGER,
BeanProxyType.LOCAL)).submitEventSync(new Event(getStoragePool().getId(),
Line 200: null, vds.getId(),
EventType.VDSCONNECTTOPOOL, "Trying to connect the host to the pool
"+getStoragePool().getId()),
Consider logging the host id/name too.
Also, please observe formatting - please replace "+" with " + "
Line 201: new Callable<EventResult>() {
Line 202: @Override
Line 203: public EventResult call() {
Line 204: return
runConnectHostToPoolEvent(getStoragePool().getId(), vds);
--
To view, visit http://gerrit.ovirt.org/13311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If192b3ccc5f5310de4fd80ca7fb4a7d74d52e1df
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
