Ori Liel has posted comments on this change.
Change subject: engine: fix add watchdog
......................................................................
Patch Set 2:
(2 comments)
RSDL builder is a little delicate when it comes to devices. It's based on
reflection, so the generic interfaces DevicesResourceD,C>, DeviceResource<D>
give it a headache.
Please make sure that replacing WatchdogsResource with
DevicesResource<WatchDogs, WatchDog> does not cause problems in RSDL
generation.
Check that the output of:
GET http://<host:port>/api?rsdl
Contains the signatures for watchdogs (getting and creation).
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResource.java
Line 63: @Override
Line 64: protected VdcActionParametersBase getAddParameters(VmWatchdog
entity, WatchDog device) {
Line 65: WatchdogParameters watchdogParameters = new
WatchdogParameters();
Line 66: validateEnums(WatchDog.class, device);
Line 67: watchdogParameters.setAction(getMapper(WatchdogAction.class,
VmWatchdogAction.class).map(WatchdogAction.valueOf(StringUtils.upperCase(device.getAction())),
use WatchDogAction.fromValue()
Line 68: null));
Line 69: watchdogParameters.setModel(getMapper(WatchdogModel.class,
VmWatchdogType.class).map(WatchdogModel.valueOf(StringUtils.upperCase(device.getModel())),
Line 70: null));
Line 71: watchdogParameters.setId(parentId);
Line 65: WatchdogParameters watchdogParameters = new
WatchdogParameters();
Line 66: validateEnums(WatchDog.class, device);
Line 67: watchdogParameters.setAction(getMapper(WatchdogAction.class,
VmWatchdogAction.class).map(WatchdogAction.valueOf(StringUtils.upperCase(device.getAction())),
Line 68: null));
Line 69: watchdogParameters.setModel(getMapper(WatchdogModel.class,
VmWatchdogType.class).map(WatchdogModel.valueOf(StringUtils.upperCase(device.getModel())),
use WatchDogModel.fromValue()
Line 70: null));
Line 71: watchdogParameters.setId(parentId);
Line 72: watchdogParameters.setVm(isVm(parentId));
Line 73: return watchdogParameters;
--
To view, visit http://gerrit.ovirt.org/17434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95362fda69b8ec7c02893ba30cdf19be7eee5eac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
