Ori Liel has posted comments on this change.
Change subject: restapi: Support for gluster hooks added
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/Stage.java
Line 1: package org.ovirt.engine.api.model;
Line 2:
Line 3: public enum Stage {
Stage is a bit of a generic name; how about HookStage?
(I'm talking just about the enum, not the element name in api.xsd)
Line 4: PRE,
Line 5: POST;
Line 6:
Line 7: public String value() {
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 3314: <xs:complexContent>
Line 3315: <xs:extension base="BaseResource">
Line 3316: <xs:sequence>
Line 3317: <xs:element ref="host" minOccurs="0" maxOccurs="1"/>
Line 3318: <xs:element name="content_type" type="xs:string"
minOccurs="0" maxOccurs="1" />
Michael meant you can also re-use an existing element in the schema, names
'Status'. As far as I'm concerned using a string here, as you do now, is also
ok.
Line 3319: <xs:element name="status" type="xs:string" minOccurs="0"
maxOccurs="1"/>
Line 3320: <xs:element name="checksum" type="xs:string" minOccurs="0"
maxOccurs="1"/>
Line 3321: </xs:sequence>
Line 3322: </xs:extension>
--
To view, visit http://gerrit.ovirt.org/16512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9c0299977448e0b50feeed6e38a015c60b86fd
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
