Laszlo Hornyak has uploaded a new change for review. Change subject: restapi: unboxing fix ......................................................................
restapi: unboxing fix Unboxing a Boolean caused NPE when the isRequired was set to null. This property is frequently set to null, therefore it seemed to make sense to avoid unboxing. Change-Id: I4081ca7db3efa828cd1ee6bd5d6a41e8682e75ff Signed-off-by: Laszlo Hornyak <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/17790/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java index 3760db9..ef02e83 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java @@ -611,7 +611,7 @@ String link1ParamType = link1.getRequest().getBody().getType(); String link2ParamType = link2.getRequest().getBody().getType(); //Verify for both links that body is not mandatory - if ( (link1.getRequest().getBody().isRequired()==false) && (link2.getRequest().getBody().isRequired()==false) ){ + if ( Boolean.FALSE.equals(link1.getRequest().getBody().isRequired()) && Boolean.FALSE.equals(link2.getRequest().getBody().isRequired()) ){ if (link1ParamType!=null && link2ParamType==null) { return link2; } -- To view, visit http://gerrit.ovirt.org/17790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4081ca7db3efa828cd1ee6bd5d6a41e8682e75ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
