Omer Frenkel has posted comments on this change.
Change subject: core: handle 'image does not exists' error on remove
hibernation vols
......................................................................
Patch Set 8:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
Line 88: suspendedVm = true;
Line 89: setSucceeded(stopSuspendedVm());
Line 90:
Line 91: // the following is true when the hibernation volumes
don't exist
Line 92: if (getSucceeded() && getTaskIdList().isEmpty()) {
it would be better not to set succeeded to true before flow is over, for
example in an error will happen inside endVmCommand() the command might still
finish as succeeded.
please set the succeeded only at the end
Line 93: endVmCommand();
Line 94: setCommandShouldBeLogged(true);
Line 95: }
Line 96: } else {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
Line 114: Guid guid = createTask(taskId, vdsRetValue);
Line 115: enclosingCommand.getTaskIdList().add(guid);
Line 116: return guid;
Line 117: }
Line 118: else {
should be in 1 line
Line 119: enclosingCommand.deleteAsyncTaskPlaceHolder(taskKey);
Line 120: // otherwise, if the command failed because the image
already does not exist,
Line 121: // no need to create and monitor task, so we return empty
guid to mark this state
Line 122: return vdsRetValue.getVdsError().getCode() ==
VdcBllErrors.ImageDoesNotExistInDomainError ?
--
To view, visit http://gerrit.ovirt.org/17474
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief52a20315b29660c7038eab1cc8dbbb4c4ded3e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
