Martin Peřina has uploaded a new change for review. Change subject: tools: Fix engine-manage-domains logging config ......................................................................
tools: Fix engine-manage-domains logging config Fixes engine-manage-domains logging config under JBoss EAP. The problem started when JBoss EAP reimplemented log4j classes in JBoss Log Manager, but logging configuration initialization from system property log4j.configuration has not been included in those reimplemented classes. This patch initializes log4j configuration for engine-manage-domains. Change-Id: I882cc4b6d859a630e3dcf2022f37c41135f25571 Bug-Url: https://bugzilla.redhat.com/994191 Signed-off-by: Martin Perina <[email protected]> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/17842/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java index 4328b43..174deda 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java @@ -12,6 +12,8 @@ import java.io.FileReader; import java.io.IOException; import java.io.InputStream; +import java.net.MalformedURLException; +import java.net.URL; import java.sql.SQLException; import java.text.SimpleDateFormat; import java.util.ArrayList; @@ -25,9 +27,13 @@ import java.util.Set; import java.util.TreeSet; +import javax.xml.parsers.FactoryConfigurationError; + import org.apache.commons.configuration.ConfigurationException; import org.apache.commons.lang.StringUtils; +import org.apache.log4j.LogManager; import org.apache.log4j.Logger; +import org.apache.log4j.xml.DOMConfigurator; import org.ovirt.engine.core.common.config.ConfigValues; import org.ovirt.engine.core.common.utils.Pair; import org.ovirt.engine.core.ldap.LdapProviderType; @@ -156,7 +162,25 @@ } } + /** + * Initializes logging configuration + */ + private static void initLogging() { + String cfgFile = System.getProperty("log4j.configuration"); + if (StringUtils.isNotBlank(cfgFile)) { + try { + URL url = new URL(cfgFile); + LogManager.resetConfiguration(); + DOMConfigurator.configure(url); + } catch (FactoryConfigurationError | MalformedURLException ex) { + System.out.println("Cannot configure logging: " + ex.getMessage()); + } + } + } + public static void main(String[] args) { + initLogging(); + ManageDomains util; util = new ManageDomains(); -- To view, visit http://gerrit.ovirt.org/17842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I882cc4b6d859a630e3dcf2022f37c41135f25571 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Peřina <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
