Alissa Bonas has posted comments on this change. Change subject: restapi: del storage conn if domain creation fails ......................................................................
Patch Set 1: Currently the backend of storage domain management doesn't differentiate between 2 situations : 1. a connection that was created as part of the same REST call - in which case it should be deleted to keep the operation atomic 2. reusing an already existing connection which was created in the past (new option in 3.3) - in which case it should not be deleted. Right now only the REST layer "knows" this difference - which option the user chose. Moreover, the webadmin UI design has the same solution - multiple commands are invoked sequentially separately (create connection, create domain) , and there's a failure callback that deletes the connection in case storage domain creation failed. -- To view, visit http://gerrit.ovirt.org/17658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e354cb10e2438fae02b1dff41b2945b016d1e1b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
