Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Show only compatible OSes
......................................................................
Patch Set 1:
(1 comment)
seems ok - just a minor comment
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 160: private static List<Integer> linuxOsIds;
Line 161: // cached windows OS
Line 162: private static List<Integer> windowsOsIds;
Line 163: // cached OS Architecture
Line 164: private static HashMap<Integer, ArchitectureType> osArchitectures;
please use Map<...> instead of HashMap<...>
Line 165:
Line 166:
Line 167: public static String getDefaultConfigurationVersion() {
Line 168: return _defaultConfigurationVersion;
--
To view, visit http://gerrit.ovirt.org/17972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19f5a2fa8ca6a54e75f4ff64c4b6189db13ed25d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
