Moti Asayag has posted comments on this change.
Change subject: engine: Add compatibility version check to qos on profiles bll
commands
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java
Line 52:
Line 53: public ValidationResult networkQosSupported() {
Line 54: return vnicProfile.getNetworkQosId() == null
Line 55: ||
FeatureSupported.networkQoS(getDbFacade().getStoragePoolDao()
Line 56: .get(getNetwork().getDataCenterId())
that is a bit problematic, cause if we block this action by the data-center
version we actually preventing from clusters in a supported version to use this
feature.
For example, cluster 3.3 can reside in dc 3.1.
In that case, i'm not sure it is the best place to block the feature on.
We might think of blocking the usage of the vnic profile on the VM which is
already placed on a cluster (so we know for sure if the feature is supported or
not).
So the can-do-action should be moved from these commands to Add/Update
Vm(template?) Interface.
Line 57: .getcompatibility_version())
Line 58: ? ValidationResult.VALID
Line 59: : new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_QOS_NOT_SUPPORTED);
Line 60: }
--
To view, visit http://gerrit.ovirt.org/18032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58f21e68f2c58792c21982f4a60f73be4c744c5e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
