Greg Padgett has uploaded a new change for review. Change subject: broker: log errors during request processing ......................................................................
broker: log errors during request processing Uncaught exceptions would previously silently kill the server threads, now they will be logged and the thread will shut down properly. Change-Id: I9e758af28b5381f21c9f27f1c9d69f529b997269 Signed-off-by: Greg Padgett <[email protected]> --- M ovirt_hosted_engine_ha/broker/listener.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-ha refs/changes/50/18050/1 diff --git a/ovirt_hosted_engine_ha/broker/listener.py b/ovirt_hosted_engine_ha/broker/listener.py index 73bd6ab..cc64039 100644 --- a/ovirt_hosted_engine_ha/broker/listener.py +++ b/ovirt_hosted_engine_ha/broker/listener.py @@ -129,6 +129,7 @@ Handle an incoming connection. """ while not self.server.sp_listener.need_exit: + data = None try: data = util.socket_readline(self.request, self._log) self._log.debug("Input: %s", data) @@ -150,6 +151,10 @@ except DisconnectionError: self._log.info("Connection closed") return + except Exception: + self._log.error("Error handling request, data: %r", + data, exc_info=True) + return if self.server.sp_listener.need_exit: self._log.info("Closing connection on server request") -- To view, visit http://gerrit.ovirt.org/18050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e758af28b5381f21c9f27f1c9d69f529b997269 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
