Allon Mureinik has posted comments on this change.
Change subject: core: Missing properties for DAO tests
......................................................................
Patch Set 1:
This isn't new, just haven't got round to it until now.
The test suite still passes, but without this patch you get the following
stacktrace printed to the screen when loading the conf:
Running org.ovirt.engine.core.dal.dbbroker.generic.DBConfigUtilsTest
07:37:43,337 INFO [LocalConfig] Loaded file
"/home/amureini/src/git/ovirt-engine/backend/manager/modules/dal/src/test/resources/engine.conf".
07:37:43,338 INFO [LocalConfig] Loaded file "/dev/null".
07:37:43,338 INFO [LocalConfig] Value of property "ENGINE_PKI_ENGINE_STORE" is
"/home/amureini/src/git/ovirt-engine/backend/manager/modules/dal/src/test/resources/key.p12".
07:37:43,338 INFO [LocalConfig] Value of property
"ENGINE_PKI_ENGINE_STORE_ALIAS" is "1".
07:37:43,338 INFO [LocalConfig] Value of property
"ENGINE_PKI_ENGINE_STORE_PASSWORD" is "NoSoup4U".
07:37:43,338 INFO [LocalConfig] Value of property "ENGINE_PKI_TRUST_STORE" is
"dummy".
07:37:43,338 INFO [LocalConfig] Value of property
"ENGINE_PKI_TRUST_STORE_PASSWORD" is "".
07:37:43,338 ERROR [LocalConfig] The property "ENGINE_DB_CONNECTION_TIMEOUT"
doesn't have a value.
07:37:43,339 WARN [DbFacadeLocator] Can't load connection checking parameters
of DB facade, will continue using the default values.
java.lang.IllegalArgumentException: The property "ENGINE_DB_CONNECTION_TIMEOUT"
doesn't have a value.
at
org.ovirt.engine.core.utils.LocalConfig.getProperty(LocalConfig.java:295)
at
org.ovirt.engine.core.utils.LocalConfig.getInteger(LocalConfig.java:395)
at
org.ovirt.engine.core.utils.LocalConfig.getInteger(LocalConfig.java:424)
at
org.ovirt.engine.core.dal.dbbroker.DbFacadeLocator.loadDbFacadeConfig(DbFacadeLocator.java:177)
at
org.ovirt.engine.core.dal.dbbroker.DbFacadeLocator.createDbFacade(DbFacadeLocator.java:62)
at
org.ovirt.engine.core.dal.dbbroker.DbFacadeLocator.getDbFacade(DbFacadeLocator.java:47)
at
org.ovirt.engine.core.dao.BaseDAOTestCase.initTestCase(BaseDAOTestCase.java:66)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27)
at
org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at
org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:71)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:47)
at org.junit.rules.RunRules.evaluate(RunRules.java:18)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:174)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:35)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:115)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:97)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at
org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
at $Proxy0.invoke(Unknown Source)
at
org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
at
org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:91)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)
This minor fix offers two improvements:
1. No ugly stacktrace on the screen
2. Test runs faster because of the 0 (instead of the default) timeout
--
To view, visit http://gerrit.ovirt.org/18044
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I371aa390a380447014825f5197661a3516beff8d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
