Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: setup: unmount error debug
......................................................................

packaging: setup: unmount error debug

added a call to lsof for helping in unmount error
debugging.

Change-Id: I9a41e309a2700be752b6758ab941618fedcca4da
Signed-off-by: Sandro Bonazzola <[email protected]>
---
M ovirt-hosted-engine-setup.spec.in
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup 
refs/changes/63/18063/1

diff --git a/ovirt-hosted-engine-setup.spec.in 
b/ovirt-hosted-engine-setup.spec.in
index ff36e25..f735007 100644
--- a/ovirt-hosted-engine-setup.spec.in
+++ b/ovirt-hosted-engine-setup.spec.in
@@ -53,6 +53,7 @@
 Requires:       ovirt-hosted-engine-ha
 Requires:       sanlock >= 2.8
 Requires:       sanlock-python >= 2.8
+Requires:       lsof
 BuildRequires:  gettext
 BuildRequires:  otopi-devel >= 1.1.0
 BuildRequires:  python2-devel
diff --git a/src/plugins/ovirt-hosted-engine-setup/storage/storage.py 
b/src/plugins/ovirt-hosted-engine-setup/storage/storage.py
index a9dd7d7..929ca18 100644
--- a/src/plugins/ovirt-hosted-engine-setup/storage/storage.py
+++ b/src/plugins/ovirt-hosted-engine-setup/storage/storage.py
@@ -93,6 +93,15 @@
             else:
                 tries -= 1
                 time.sleep(1)
+                #rc, stdout and stderr are automatically logged as debug
+                self.execute(
+                    (
+                        self.command.get('lsof'),
+                        '+D%s' % path,
+                        '-xfl'
+                    ),
+                    raiseOnError=False
+                )
         return rc
 
     def _handleHostId(self):
@@ -480,6 +489,7 @@
     def _setup(self):
         self.command.detect('mount')
         self.command.detect('umount')
+        self.command.detect('lsof')
 
     @plugin.event(
         stage=plugin.Stages.STAGE_CUSTOMIZATION,


-- 
To view, visit http://gerrit.ovirt.org/18063
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a41e309a2700be752b6758ab941618fedcca4da
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to