Martin Peřina has uploaded a new change for review. Change subject: tools: Fix engine-config logging config ......................................................................
tools: Fix engine-config logging config Fixes engine-config logging config under JBoss EAP. The problem started when JBoss EAP reimplemented log4j classes in JBoss Log Manager, but logging configuration initialization from system property log4j.configuration has not been included in those reimplemented classes. This patch initializes log4j configuration for engine-config. Change-Id: I7a125f58bf6450c5d0a1ff4d998fb0d1865da991 Bug-Url: https://bugzilla.redhat.com/996962 Signed-off-by: Martin Perina <[email protected]> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/18073/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java index c3b35bb..1a3b419 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java @@ -1,8 +1,15 @@ package org.ovirt.engine.core.config; import java.io.File; +import java.net.MalformedURLException; +import java.net.URL; +import javax.xml.parsers.FactoryConfigurationError; + +import org.apache.commons.lang.StringUtils; +import org.apache.log4j.LogManager; import org.apache.log4j.Logger; +import org.apache.log4j.xml.DOMConfigurator; import org.ovirt.engine.core.config.validation.ConfigActionType; import org.ovirt.engine.core.tools.ToolConsole; import org.ovirt.engine.core.utils.EngineLocalConfig; @@ -45,12 +52,29 @@ } /** + * Initializes logging configuration + */ + private static void initLogging() { + String cfgFile = System.getProperty("log4j.configuration"); + if (StringUtils.isNotBlank(cfgFile)) { + try { + URL url = new URL(cfgFile); + LogManager.resetConfiguration(); + DOMConfigurator.configure(url); + } catch (FactoryConfigurationError | MalformedURLException ex) { + System.out.println("Cannot configure logging: " + ex.getMessage()); + } + } + } + + /** * The main method, instantiates the parser and executes. * * @param args * The arguments given by the user. */ public static void main(String... args) { + initLogging(); try { getInstance().setParser(new EngineConfigCLIParser()); getInstance().setUpAndExecute(args); -- To view, visit http://gerrit.ovirt.org/18073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a125f58bf6450c5d0a1ff4d998fb0d1865da991 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
