Michael Pasternak has posted comments on this change.
Change subject: restapi: image entity and import from glance
......................................................................
Patch Set 3: Code-Review+2
(4 comments)
+2 *after* addressing comments from this pacth
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImagesResource.java
Line 31: getImagesListParams.setForceRefresh(true);
Line 32: return
mapCollection(getBackendCollection(VdcQueryType.GetImagesList,
getImagesListParams));
Line 33: }
Line 34:
Line 35: @Override
please add;
@SingleEntityResource
Line 36: public ImageResource getDeviceSubResource(String id) {
Line 37: return inject(new BackendStorageDomainImageResource(id, this));
Line 38: }
Line 39:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
Line 338:
Line 339: private void addStorageDomainImageFeature(Features features) {
Line 340: Feature feature = new Feature();
Line 341: feature.setName("Image Storage Domains");
Line 342: feature.setDescription("Importing and exporting images from
and to image storage domain (as for example OpenStack glance)");
please mention that this feature is a "teach preview"
Line 343: features.getFeature().add(feature);
Line 344: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResourceTest.java
Line 18: public BackendStorageDomainImageResourceTest() {
Line 19: super(new
BackendStorageDomainImageResource(IMAGE_ID.toString(),
Line 20: new BackendStorageDomainImagesResource(DOMAIN_ID)));
Line 21: }
Line 22:
please add test for import
Line 23: @Test
Line 24: public void testGet() {
Line 25: setUriInfo(setUpBasicUriExpectations());
Line 26: setUpEntityQueryExpectations(
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImagesResourceTest.java
Line 75: @Override
Line 76: @Ignore
Line 77: public void testListCrashClientLocale() throws Exception {
Line 78: }
Line 79:
you should not ignore this three tests
Line 80: @Override
Line 81: protected void verifyModel(Image model, int index) {
Line 82: verifyModelSpecific(model, index);
Line 83: verifyLinks(model);
--
To view, visit http://gerrit.ovirt.org/17348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9104ff0eba175c90b42bc5651ada0f688eeb00
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
