Shahar Havivi has uploaded a new change for review. Change subject: Engine: Sometimes migration message is not logged ......................................................................
Engine: Sometimes migration message is not logged Changing the _vmDict from HashMap to ConcurrentHashMap. Missing synchronization on this object may be the reason why we get misleading event log messages. Change-Id: I665707881145a486e926274b79d661c89b1385ec Bug-Url: https://bugzilla.redhat.com/970928 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/18164/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java index 5a56b2e..78e3f33 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java @@ -12,6 +12,7 @@ import java.util.Map; import java.util.Map.Entry; import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.atomic.AtomicBoolean; import org.apache.commons.lang.ObjectUtils; @@ -117,7 +118,7 @@ private final VdsManager _vdsManager; private final MonitoringStrategy monitoringStrategy; private final VDS _vds; - private final Map<Guid, VM> _vmDict; + private final ConcurrentHashMap<Guid, VM> _vmDict; private boolean processHardwareCapsNeeded; private boolean refreshedCapabilities = false; private static Map<Guid, Long> hostDownTimes = new HashMap<Guid, Long>(); @@ -378,7 +379,7 @@ _vds = vds; _firstStatus = _vds.getStatus(); this.monitoringStrategy = monitoringStrategy; - _vmDict = getDbFacade().getVmDao().getAllRunningByVds(_vds.getId()); + _vmDict = new ConcurrentHashMap<Guid, VM>(getDbFacade().getVmDao().getAllRunningByVds(_vds.getId())); for (VM vm : _vmDict.values()) { if (vm.isRunning() && vm.getStatus() != VMStatus.Up) { -- To view, visit http://gerrit.ovirt.org/18164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I665707881145a486e926274b79d661c89b1385ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
